-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newtonsoft.json from 11.0.2 to 13.0.1 #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I wouldn't be surprised if we had some test projects that also needed to be updated.
@@ -41,7 +41,7 @@ | |||
|
|||
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | |||
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="2.2.0" /> | |||
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" /> | |||
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to just remove this entirely since it's picked up transitively from DurableTask.Core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good idea. Will do
Note that this comment only applies to Durable Functions and not to any direct consumers of this framework. |
Do we need to do any version rev for this? |
This will remove certain static analysis warnings due to vulnerabilities. At runtime, our dependency is already being replaced with the newtonsoft.json version brought in by WebJobs, which is already
13.0.1
, so this change should be safe.The change also required that we update the code in a few places to account for the possibility of the deserialization returning
null
. You will a few types being updated to include the?
modifier as a result.