Patch tests post Newtonsoft.Json upgrade to 13.0.1 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
requested changes
Mar 28, 2023
| Assert.IsTrue(details.IsCausedBy<Exception>()); // check that base types work too | ||
| Assert.AreEqual("This is a test exception", details.ErrorMessage); | ||
| Assert.IsNotNull(details.StackTrace); | ||
| Assert.AreEqual(typeof(InvalidOperationException).FullName, details?.ErrorType); |
There was a problem hiding this comment.
It's technically not correct for us to add the ? here (and below) because we already did the null check above in Assert.IsNotNull(details). If the compiler is still making you check for null, it might be because the version of Assert.IsNotNull we're calling doesn't have the right attributes on it. In that case, we should use ! instead of ? to suppress subsequent warnings.
There was a problem hiding this comment.
Fancy. Will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #870
It appears that CI did not run on the PR above, leading to broken tests post-merge. This PR fixes that by updating our Newtonsoft references across the test projects