Allow = character in parameter value #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with this change, since it maps to the platform URL parsing behavior |
daviwil
approved these changes
Jan 21, 2021
|
Do we have the same problem in |
joheredi
force-pushed
the
query-equals
branch
from
17a6451
to
4bf3c51
Compare
joheredi
force-pushed
the
query-equals
branch
from
4bf3c51
to
d8215db
Compare
I just checked and this is not an issue in core-http |
|
Merging, the only non-passing test is the check-everything. I'm not updating the package version in favor of #410 which is updating the version and we want both fixes to be part of the same release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ms-rest-js marks a query parameter as invalid and drops it if it contains an
=character.According to RFC 3896 "reserved" characters should be encoded (link). However, nodejs and browser's native URL seems to handle = in the parameter value just fine.
With this PR ms-rest-js parsing will allow
=in a query parameter value.Fixes #406