Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TokenCredential adapter #410

Merged
merged 9 commits into from
Jan 26, 2021
Merged

Add TokenCredential adapter #410

merged 9 commits into from
Jan 26, 2021

Conversation

deyaaeldeen
Copy link
Member

Enables using identity's TokenCredential using an adapter that converts to ServiceClientCredentials.

TODO

  • make a release.

ramya-rao-a
ramya-rao-a reviewed Jan 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
ramya-rao-a
ramya-rao-a reviewed Jan 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
daviwil
daviwil approved these changes Jan 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
joheredi
joheredi approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@joheredi joheredi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You'll need to bump the package version for the CI build to pass and allow us to release

@ramya-rao-a
Copy link
Contributor

Looks good! You'll need to bump the package version for the CI build to pass and allow us to release

@joheredi Don't we want to include #408 in the release as well? Or do we want to do multiple releases?

ramya-rao-a
ramya-rao-a approved these changes Jan 22, 2021
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@joheredi
Copy link
Member

Looks good! You'll need to bump the package version for the CI build to pass and allow us to release

@joheredi Don't we want to include #408 in the release as well? Or do we want to do multiple releases?

We should release both at the same time. I'll merge the PR and kick off the release once both PRs are merged

@joheredi joheredi mentioned this pull request Jan 25, 2021
Merged
@deyaaeldeen deyaaeldeen mentioned this pull request Jan 26, 2021
Merged
@deyaaeldeen deyaaeldeen merged commit 1daaea5 into Azure:master Jan 26, 2021
@deyaaeldeen deyaaeldeen deleted the add-identity-adapter branch January 26, 2021 21:38
@deyaaeldeen deyaaeldeen mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheredi joheredi joheredi approved these changes

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@daviwil daviwil daviwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deyaaeldeen @ramya-rao-a @joheredi @daviwil