Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for introducing the SONiC Platform Development Env (Re… #7510

Merged
merged 36 commits into from
Jul 24, 2021
Merged

Initial commit for introducing the SONiC Platform Development Env (Re… #7510

merged 36 commits into from
Jul 24, 2021

Conversation

geans-pin
Copy link
Contributor

@geans-pin geans-pin commented May 4, 2021

What I did
This PR is a resubmit of PR#3778

How I did it
The PDE silicon test harness and platform test harness can be found in
src/sonic-platform-pdk-pde

How to verify it
You must have both this PR and PR below.
sonic-net/sonic-platform-pdk-pde#28

Enable PDE by un-commenting line in rules/config
INCLUDE_PDE=y

Currently only Broadcom support has been added.

Description for the changelog
Adding support for Platform Development Environment (PDE)

@lgtm-com
Copy link

lgtm-com bot commented May 4, 2021

This pull request introduces 4 alerts when merging 138a7fe41449ce3814d5f85e260ba542eacf3091 into b2286a2 - view on LGTM.com

new alerts:

  • 4 for Unused import

Makefile.work Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2021

This pull request introduces 4 alerts when merging c152419 into 0bc0f98 - view on LGTM.com

new alerts:

  • 4 for Unused import

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7510 in repo Azure/sonic-buildimage

@adyeung
Copy link
Collaborator

adyeung commented May 26, 2021

@jleveque Pls help review

Makefile.work Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request introduces 4 alerts when merging 1945c12 into 2cd61bc - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2021

This pull request introduces 4 alerts when merging 38592f9 into 237849a - view on LGTM.com

new alerts:

  • 4 for Unused import

dockers/docker-pde/base_image_files/pde-bench Outdated Show resolved Hide resolved
dockers/docker-pde/docker_init.sh Outdated Show resolved Hide resolved
dockers/docker-pde/stress-sfp-i2c.py Outdated Show resolved Hide resolved
platform/broadcom/sonic-pde-tests.dep Outdated Show resolved Hide resolved
platform/broadcom/sonic-pde-tests.dep Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2021

This pull request introduces 4 alerts when merging d0f6bb2 into 1a3cab4 - view on LGTM.com

new alerts:

  • 4 for Unused import

@geans-pin
Copy link
Contributor Author

jleveque,

I have fixed the review comment. However, the kvm test is fail in the checker which seems not related with the fix.
Can you re-run the pipeline build ?

Geans

@geans-pin
Copy link
Contributor Author

/azure-pipelines

@geans-pin geans-pin requested review from jleveque and xumia June 5, 2021 13:34
@geans-pin
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geans-pin
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Jul 2, 2021

Sorry for misleading. I notice an unexpected file src/sonic-platform-pde/.gitkeep
Please double check the page https://git-scm.com/book/en/v2/Git-Tools-Submodules


In reply to: 873021616

@geans-pin
Copy link
Contributor Author

Thanks qiluo, Here we are.. Just committed the fix

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule looks good now. Please check with other reviewers.

@geans-pin
Copy link
Contributor Author

xumia, jleveque, lguohan,

All of the reviewed comments are fixed and build are Pass.
Are we ready for the merge ?

Geans

@anshuv-mfst
Copy link

anshuv-mfst commented Jul 7, 2021

Hi @xumia , @qiluo-msft - can you please approve and merge by/before 7/9, this PR is needed in 202106 release.

@adyeung
Copy link
Collaborator

adyeung commented Jul 22, 2021

@xumia, @qiluo-msft, @lguohan, @anshuv-mfst, pls help approve and merge

rules/config Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
Makefile.work Outdated Show resolved Hide resolved
Makefile.work Outdated Show resolved Hide resolved
Makefile.work Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
@geans-pin
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan lguohan merged commit aa59bfe into sonic-net:master Jul 24, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
The PDE silicon test harness and platform test harness can be found in
src/sonic-platform-pdk-pde
@MikeHcChen
Copy link

MikeHcChen commented Jan 18, 2022

Recently, I tried to build PDE environment with 202111 branch codes.
I added "INCLUDE_PDE = y" and "PDDF_SUPPORT = y" in "sonic-buildimage/rules/config" file and
revised "sonic-buildimage/dockers/docker-pde/Dockerfile.j2" as following:
--- a/dockers/docker-pde/Dockerfile.j2
+++ b/dockers/docker-pde/Dockerfile.j2
@@ -1,4 +1,4 @@
-FROM {{ docker_pde_load_image }}
+FROM docker-config-engine-buster

Then I tried to build PDE using commands "make init;make configure PLATFORM=broadcom; make target/sonic-broadcom-pde.bin". I found I can get docker-pde.gz (PDE docker) and sonic-platform-pde_1.0_amd64.deb, but cannot get sonic-broadcom-pde.bin. The error logs like:

make: *** No rule to make target 'target/sonic-broadcom-pde.bin'. Stop.
Makefile.work:304: recipe for target 'target/sonic-broadcom-pde.bin' failed
make[1]: *** [target/sonic-broadcom-pde.bin] Error 2
make[1]: Leaving directory '/home/mike/sonic_202111_branch/sonic-buildimage'
Makefile:30: recipe for target 'target/sonic-broadcom-pde.bin' failed
make: *** [target/sonic-broadcom-pde.bin] Error 2

Is there anything I should add to make the PDE image in SONiC?
Any idea is welcome. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants