-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for introducing the SONiC Platform Development Env (Re… #7510
Conversation
This pull request introduces 4 alerts when merging 138a7fe41449ce3814d5f85e260ba542eacf3091 into b2286a2 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging c152419 into 0bc0f98 - view on LGTM.com new alerts:
|
Commenter does not have sufficient privileges for PR 7510 in repo Azure/sonic-buildimage |
@jleveque Pls help review |
This pull request introduces 4 alerts when merging 1945c12 into 2cd61bc - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 38592f9 into 237849a - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging d0f6bb2 into 1a3cab4 - view on LGTM.com new alerts:
|
jleveque, I have fixed the review comment. However, the kvm test is fail in the checker which seems not related with the fix. Geans |
/azure-pipelines |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Sorry for misleading. I notice an unexpected file src/sonic-platform-pde/.gitkeep In reply to: 873021616 |
Thanks qiluo, Here we are.. Just committed the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submodule looks good now. Please check with other reviewers.
xumia, jleveque, lguohan, All of the reviewed comments are fixed and build are Pass. Geans |
Hi @xumia , @qiluo-msft - can you please approve and merge by/before 7/9, this PR is needed in 202106 release. |
@xumia, @qiluo-msft, @lguohan, @anshuv-mfst, pls help approve and merge |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PDE silicon test harness and platform test harness can be found in src/sonic-platform-pdk-pde
Recently, I tried to build PDE environment with 202111 branch codes. Then I tried to build PDE using commands "make init;make configure PLATFORM=broadcom; make target/sonic-broadcom-pde.bin". I found I can get docker-pde.gz (PDE docker) and sonic-platform-pde_1.0_amd64.deb, but cannot get sonic-broadcom-pde.bin. The error logs like: make: *** No rule to make target 'target/sonic-broadcom-pde.bin'. Stop. Is there anything I should add to make the PDE image in SONiC? |
What I did
This PR is a resubmit of PR#3778
How I did it
The PDE silicon test harness and platform test harness can be found in
src/sonic-platform-pdk-pde
How to verify it
You must have both this PR and PR below.
sonic-net/sonic-platform-pdk-pde#28
Enable PDE by un-commenting line in rules/config
INCLUDE_PDE=y
Currently only Broadcom support has been added.
Description for the changelog
Adding support for Platform Development Environment (PDE)