[config] Fix some issues in config. #2416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LTeng <liuteng@asterfusion.com>
Signed-off-by: LTeng <liuteng@asterfusion.com>
Signed-off-by: LTeng <liuteng@asterfusion.com>
maipbui
reviewed
Jun 29, 2023
config/main.py
Outdated
| @@ -4717,7 +4717,7 @@ def remove_queue(db, interface_name, queue_map): | |||
| # 'cable_length' subcommand | |||
| # | |||
|
|
|||
| @interface.command() | |||
| @interface.command("cable_length") | |||
|
Please resolve conflicts and merge latest master code to trigger Semgrep. |
Signed-off-by: LTeng <liuteng@asterfusion.com>
Signed-off-by: LTeng <liuteng@asterfusion.com>
|
Please add unit test to cover this change. |
Signed-off-by: LTeng <liuteng@asterfusion.com>
Updated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: LTeng liuteng@asterfusion.com
What I did
Fix #2415
1、At config/config_mgmt.py:648, there is "Exce" which looks like it should be "Exception".
2、Cmd "config mirror_session erspan add": gre_type is not required. validate_gre_type raise " AttributeError: 'NoneType' object has no attribute 'lower' " if gre_type is not provided.
3、Cmd "config interface cable_length": It is actually "config interface cable-length" at running time and caused by click 7.0 . And It is inconsistent with Command-Reference.
4、Cmd "config route del": In "if not tuple(key.split("|")) in keys and not prefix_tuple in keys", these two look the same.
5、Cmd "config sflow polling-interval": echo error but no return.
How I did it
1、Replace "Exce" with "Exception".
2、Add check: value is not None.
3、assign the name explicitly.Modified comments of priority-group for the same reason.
4、Remove one of them.
5、Replace "click.echo" with "ctx.fail".
How to verify it
Added unit tests.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)