Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: waf tests and integration test framework #10

Merged
merged 48 commits into from
Mar 28, 2024
Merged

feat: waf tests and integration test framework #10

merged 48 commits into from
Mar 28, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Mar 25, 2024 •
edited
Loading

Adds two new kinds of rule:

  1. SimpleRule - uses generics to check simple values from a resource, also supports nested blocks
  2. NullRule - ensures that the default value of a supplied attribute is null, or references a variabel with no default value.

Adds integration test framework to ensure plugin works with compiled rules.

@matt-FFFFFF matt-FFFFFF mentioned this pull request Mar 25, 2024
Closed
@matt-FFFFFF matt-FFFFFF requested a review from lonegunmanb March 25, 2024 17:05
@matt-FFFFFF
Copy link
Member Author

@lonegunmanb please can you review

matt-FFFFFF
matt-FFFFFF commented Mar 26, 2024
View reviewed changes
attrvalue/set.go Outdated Show resolved Hide resolved
matt-FFFFFF and others added 22 commits March 26, 2024 11:23
@matt-FFFFFF
chore: go mod tidy
dc43a96
@matt-FFFFFF
feat: add app gateway sku nested block rule
2bb7161
@lonegunmanb
refactor list_value
a372740
@lonegunmanb
refactor null_value
453a397
@lonegunmanb
refactor null_value
62407f5
@lonegunmanb
refactor, move interfaces rule registry code into interfaces package
2bb774c
@lonegunmanb
keep refactor
c3a43c2
@matt-FFFFFF
fix: unknown rule now evaluates correctly
a6dde0e
@matt-FFFFFF
chore: go get upgrade
037e912
@matt-FFFFFF
Waf-refactor-2 (#12)
a8878fa 
* spike: wdyt

* feat: use new backend
@matt-FFFFFF
refactor: list
b18c7b0
@lonegunmanb
commit for now
067bc55
@lonegunmanb
use gostub to inject mock fs
52fbb31
@matt-FFFFFF
chore: go mod tidy
f48b75a
@matt-FFFFFF
chore: gitignore
97c07d2
@matt-FFFFFF
fix: update interfaces and add tags
b49ed51
@matt-FFFFFF
feat: add tags to interface spec
06db05b
@matt-FFFFFF
feat: update rules ready for release
8316be4
@matt-FFFFFF
feat: add link to vnet gw
bdb772e
@matt-FFFFFF
fix: add null/unknown checks
670af46
@matt-FFFFFF
fix: interfaces
85d6139
@matt-FFFFFF
fix: integration tests
58d5fc8
@matt-FFFFFF matt-FFFFFF merged commit 546d015 into main Mar 28, 2024
6 checks passed
@matt-FFFFFF matt-FFFFFF deleted the waf-refactor branch March 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonegunmanb lonegunmanb Awaiting requested review from lonegunmanb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-FFFFFF @lonegunmanb