Add integration test to ensure that the plugin works with the tflint we're using #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we investigate this integration test structure and adapt? @lonegunmanb https://github.com/terraform-linters/tflint-ruleset-aws/tree/v0.30.0/integration |
|
@lonegunmanb please consider #10 I have implemented the same integration test framework as the aws provider. Can we close this now? |
matt-FFFFFF
added a commit
that referenced
this pull request
Mar 28, 2024
* feat: implement waf check framework and include starter * chore: go minimum 1.22 * chore: rename func * fix: incorrect resource type * style: refactor names for readability * docs: add code comments * test: add test for optional() * feat: add generic simple rule * chore: gitignore * feat: generic simple value tests * feat: add more roles * refactor code * improve set compare * simplify toPtr function * feat: add integration test framework Supersedes #8 * build: go deps * fix: build error * test: exclude integration tests from unit * ci: fix e2e build output on windows * feat: add null value check * docs: comments * refactor: move common funcs into module_content * refactor: use github.com/deckarep/golang-set/v2 * refactor: simplify simplerule to support nested blocks * chore: go mod tidy * feat: add app gateway sku nested block rule * refactor list_value * refactor null_value * refactor null_value * refactor, move interfaces rule registry code into interfaces package * keep refactor * fix: unknown rule now evaluates correctly * chore: go get upgrade * Waf-refactor-2 (#12) * spike: wdyt * feat: use new backend * refactor: list * commit for now * use gostub to inject mock fs * chore: go mod tidy * chore: gitignore * fix: update interfaces and add tags * feat: add tags to interface spec * feat: update rules ready for release * feat: add link to vnet gw * fix: add null/unknown checks * fix: interfaces * fix: integration tests --------- Co-authored-by: zjhe <lonegunmanb@hotmail.com>
|
Closing as implemented in #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.