-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] SubjectName/Issuer (SNI) authentication. WithSendx5c() #219
Comments
hi @henrik-me, @sangonzal, any idea if we have an ETA for this? |
I may try and take a stab at this |
We don't have a fixed date for this yet, however will work with @thebenwaters on his PR. We already have a top level design for the work already, however a brief look at the PR provided indicates that you may be looking for something else/more. In our planning session today we will explore when we can pick up this work as well as how we can help you the best. |
Implemented by #285, and part of the 1.7.1 release |
Supported in:
Python
.NET
Background of SNI: How does it work?
The following description is derived from Matt Bearup, a software developer from Microsoft.
az login --newoption /path/tocert
. MSAL needs to help enable this.How does it need to be implemented in MSAL?
What the “x5c” JWT header value would be? It appears only public certificate is sufficient. MSAL do NOT need to, and MUST NOT send private cerficate.
Sagar: Correct, the x5c is the public cert.
With “x5c” available, why “x5t” is still required, since it can be generated from “x5c” through sha1 hash easily?
Sagar: This is due to the way JWT header is validated in eSTS for an incoming client assertion. eSTS parses the JWT header and extracts the x5t, does not generate it.
The "x5c" parameter means "X.509 Certificate Chain", which is represented as a JSON array of certificate value strings. See this example too. Historically AAD would also accept a single cert as a string. MSAL Python would NOT rely on such behavior, and would still follow this specs and send it as an array. During the implementation, please test it on the wire, and then also come up with a test case to ensure such behavior.
As a reference, this was the same feature we added in ADAL Python, but it was sending public cert as a string (rather than an array).
We would also like to include the usability enhancement mentioned in this ADAL Python issue, and then also back port such enhancement to ADAL Python.
The text was updated successfully, but these errors were encountered: