Allow support for a chained certificate / pkcs12 file off the bat #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thebenwaters was you able to E2E test this ? |
|
@SomkaPe working on resolving backend issue. on paper it should work |
|
@SomkaPe I asked the owner of the app 55e7e5af-ca53-482d-9aa3-5cb1cc8eecb5 for access to configure SNI so we can have full integration testing |
Merged
|
This has been accepted and merged. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to tackle #219
It seems via the code that SNI is "supported by default"
https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/src/main/java/com/microsoft/aad/msal4j/JwtHelper.java#L52
This goes ahead and sets multiple certificates to the x5c header and it's also already using x5t
The issue seems that when supporting a chained certificate, it's currently hardcoded to only accept one certificate and not a chain.
I'm not a Java guy and this is not pretty code and a decent amount of stackoverflow/googling
Please help critique the code so it's up to standards, but the goal of the PR is to support a list of x509 certificates instead of a single cert