Feature/angular 13 #4467
Feature/angular 13 #4467
Conversation
sandrooco
requested review from
jasonnutter,
jo-arroyo,
peterzenz and
tnorling
as code owners
ghost
assigned 
|
|
|
@sandrooco Thanks for opening this! We'll take a look and provide feedback. |
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
|
bumping to show interest! Would love to see this implemented |
lib/msal-angular/package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "@azure/msal-browser": "^2.21.0", | ||
| "rxjs": "^6.0.0" | ||
| "rxjs": "^7.5.0" |
There was a problem hiding this comment.
Isn't it possible to support both rxjs 6 and 7 (Same as Angular does currently)?
e.g.
"rxjs": "^6.5.3 || ^7.5.0",
There was a problem hiding this comment.
Agree, given dropping support for v6 would be a breaking change, which we will not accept.
There was a problem hiding this comment.
I updated the rxjs range accordingly to support latest 6.x to 7.x.
There was a problem hiding this comment.
@sandrooco Apologies for the delayed response, thanks for addressing. To confirm, the updated import statements are compatible with v6 and v7 (this was my biggest concern)?
There was a problem hiding this comment.
@jasonnutter Thanks for checking in.
Actually you are right - the new imports are not compatible. (7.1.0 is the last version with the old imports.) If I'm not mistaken msal can live with 7.x and the customer project with 6.x.
Also I honestly don't understand why dropping 6.x support would be a problem. In my opinion, people should upgrade to the latest 7.x version because 7.5 also is the default when setting up Angular 13 projects.
What do you think?
There was a problem hiding this comment.
How would this work for older versions of Angular (MSAL Angular v2 still supports Angular 9-12)?
There was a problem hiding this comment.
i.e. apps that still have rxjs@6 (the point being we can't update to 7 if it would break apps on older versions of rxjs).
sandrooco
requested review from
sameerag,
hectormmg,
samuelkubai,
bmahall and
pkanher617
as code owners
|
Reminder: The next release is scheduled for next week and this PR appears to be stale :( If changes have been requested please address feedback. |
|
@jasonnutter Please review :) |
|
Thanks everyone for their patience, apologies for the delay in getting this update figured out. @Robbie-Microsoft from our team will be working to get this work over the line. @sandrooco We'll be retargeting this PR against a new branch, both so that we can get the CI/CD fully running and so that we can add a couple other things before we can merge into |
Nice, thanks! Should we close this PR then? |
|
I'm oh so glad that someone has pushed the ball rolling :) |
|
any update on this push? |
We're planning to have this addressed by our next release (April 4). |
|
Closing in favor on #4605, which will be released today. |
This PR includes updates for msal-angular.