Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAL-Angular Angular13 Support & RxJS 6/7 Sample Apps #4605

Merged
merged 16 commits into from
Mar 30, 2022

Conversation

Robbie-Microsoft
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library. labels Mar 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #4605 (a6da3cc) into dev (f2ee16c) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ *Carryforward flag
msal-angular 96.39% <ø> (ø)
msal-browser 87.80% <ø> (ø) Carriedforward from dda37e5
msal-common 85.08% <ø> (ø) Carriedforward from dda37e5
msal-core 82.67% <ø> (ø) Carriedforward from dda37e5
msal-node 82.20% <ø> (ø) Carriedforward from dda37e5
msal-node-extensions 76.03% <ø> (ø) Carriedforward from dda37e5
msal-react 92.46% <ø> (ø) Carriedforward from dda37e5
node-token-validation 83.41% <ø> (ø) Carriedforward from dda37e5

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this looks good, thanks! I've push up one commit to remove the package-lock files.

Please complete the following:

  1. Generate change file (can mark as minor change)
  2. Add both of these samples to the e2e tests (@jo-arroyo can help you get that running)
  3. Add 13 as supported verison in the supported version table in the MSAL Angular README
  4. As fast follow up to this PR, start another PR to add an Angular 14 sample.

Copy link
Collaborator

@jo-arroyo jo-arroyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested locally. Great work! A few more changes would be nice:

  1. Update the READMEs for each sample, cf. Angular 10 sample.
  2. Update the README for the msal-angular-v2-samples folder. This is where we list the differences between the samples. Feel free to include an explanation for why we have a RxJS 6 and RxJS 7 sample.
  3. Update the MSAL Angular README to include links to angular13 samples.
  4. Remove the .vscode and assets folders for each sample.

I will reach out to you offline about the e2e tests.

…de and assets folders from both Angular13 samples. Added the Angular 12 sample's e2e tests to the Angular 13 samples - they do not run yet.
@jasonnutter
Copy link
Contributor

@Robbie-Microsoft E2E tests are passing. It required that I add compilerOptions.paths entries for Angular to both samples (which do in the other samples), and for rxjs for the rxjs7 sample. Example:

"paths": {
"@angular/*": ["./node_modules/@angular/*"],
"rxjs": ["./node_modules/rxjs"]
}

It would probably be good to call this out for each sample.

Copy link
Contributor

@jasonnutter jasonnutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting this together!

Copy link
Collaborator

@jo-arroyo jo-arroyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, thanks!

@Robbie-Microsoft Robbie-Microsoft changed the title Angular13 RxJS 6/7 Sample Apps MSAL-Angular Angular13 Support & RxJS 6/7 Sample Apps Mar 30, 2022
Copy link
Collaborator

@jo-arroyo jo-arroyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for all your good work!

@Robbie-Microsoft Robbie-Microsoft merged commit 5a6853e into dev Mar 30, 2022
@Robbie-Microsoft Robbie-Microsoft deleted the angular13-sample-apps branch March 30, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants