[iOS SDK] JIT Registration, Network implementation #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrescu84
requested review from
antonioalwan and
juan-arias
and removed request for
a team
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| 28AF42FB2D96C15A009D1065 /* SignInAfterSignUpStateTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 28AF42F92D96C14F009D1065 /* SignInAfterSignUpStateTests.swift */; }; | ||
| 28AF42FD2D96CBCF009D1065 /* SignInAfterResetPasswordTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 28AF42FC2D96CBC2009D1065 /* SignInAfterResetPasswordTests.swift */; }; | ||
| 28AF42FE2D96CBCF009D1065 /* SignInAfterResetPasswordTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 28AF42FC2D96CBC2009D1065 /* SignInAfterResetPasswordTests.swift */; }; | ||
| 28B28B832C6F46E50030D5C5 /* MFAStates.swift in Sources */ = {isa = PBXBuildFile; fileRef = 28B28B822C6F46E50030D5C5 /* MFAStates.swift */; }; |
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
spetrescu84
commented
Apr 9, 2025
...responses/validator/jit/validated_response/MSALNativeAuthJITChallengeValidatedResponse.swift
Outdated
Show resolved
Hide resolved
spetrescu84
commented
Apr 9, 2025
.../responses/validator/jit/validated_response/MSALNativeAuthJITContinueValidatedResponse.swift
Outdated
Show resolved
Hide resolved
...esponses/validator/jit/validated_response/MSALNativeAuthJITIntrospectValidatedResponse.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/errors/MSALNativeAuthErrorMessage.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/errors/jit/MSALNativeAuthJITContinueOauth2ErrorCode.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/errors/jit/MSALNativeAuthJITChallengeResponseError.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/responses/jit/MSALNativeAuthJITChallengeResponse.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/responses/jit/MSALNativeAuthJITContinueResponse.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/responses/jit/MSALNativeAuthJITIntrospectResponse.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
MSAL/src/native_auth/network/responses/validator/jit/MSALNativeAuthJITResponseValidator.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
.../responses/validator/jit/validated_response/MSALNativeAuthJITContinueValidatedResponse.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 10, 2025
.../native_auth/network/responses/validator/sign_up/MSALNativeAuthSignUpResponseValidator.swift
Show resolved
Hide resolved
Yuki-YuXin
reviewed
Apr 14, 2025
MSAL/src/native_auth/network/responses/validator/jit/MSALNativeAuthJITResponseValidator.swift
Outdated
Show resolved
Hide resolved
MSAL/src/native_auth/network/responses/validator/jit/MSALNativeAuthJITResponseValidator.swift
Outdated
Show resolved
Hide resolved
Yuki-YuXin
approved these changes
Apr 14, 2025
.../responses/validator/jit/validated_response/MSALNativeAuthJITContinueValidatedResponse.swift
Outdated
Show resolved
Hide resolved
Contributor
|
@spetrescu84 I was not able to find the changes to the "SignInValidator" class, where we parse the new response "registration required". Did you add this change in this PR? |
Contributor
Author
@nilo-ms I pushed now the code, there is no way to decouple the response of the token from the one of the controller so I needed to change the controller also. It's actually in multiple places - SignInValidator and TokenValidator |
nilo-ms
reviewed
Apr 15, 2025
MSAL/src/native_auth/network/responses/validator/jit/MSALNativeAuthJITResponseValidator.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 15, 2025
...responses/validator/jit/validated_response/MSALNativeAuthJITChallengeValidatedResponse.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 15, 2025
MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 15, 2025
MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift
Outdated
Show resolved
Hide resolved
…SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>
…SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>
nilo-ms
approved these changes
Apr 15, 2025
Yuki-YuXin
approved these changes
Apr 17, 2025
nilo-ms
reviewed
Apr 17, 2025
MSAL/src/native_auth/network/errors/jit/MSALNativeAuthJITChallengeResponseError.swift
Show resolved
Hide resolved
nilo-ms
reviewed
Apr 17, 2025
spetrescu84
force-pushed
the
spetrescu/jit-network-implementation
branch
from
c87fda2 to
0abcba4
Compare
spetrescu84
merged commit 069d47d
into
feature/just-in-time-registration
12 checks passed
spetrescu84
added a commit
that referenced
this pull request
Apr 22, 2025
* Native auth: Just in time SDK mock interface (#2555) * add new state and delegate for JIT * add mock implementation and update for signIn after singUp and SSPR delegates * Add callback also to signIn password delegate * make jit state methods public * use right callback method name * [iOS SDK] JIT Registration, Network implementation (#2576) * Added JIT classes * Jit classes * Controllers * New controllers * Moved controller * Changes for PR * Cleanup * Revert controller changes * Reverted changes on dispatchers * Fixed unit tests * remove non network files * Unit tests * Removed failing tests * PR comments * PR Comments * Swiftlint * Unit tests * Add error validation for invalid verification contact * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Moved code to KnonwnESTSAPIErrorCodes * Moved to error case * Integration tests * Added comment --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * [iOS SDK] JIT Registration, Business implementation (#2583) * Added JIT classes * Jit classes * Controllers * New controllers * Moved controller * Changes for PR * Cleanup * Revert controller changes * Reverted changes on dispatchers * Fixed unit tests * remove non network files * Unit tests * Removed failing tests * PR comments * PR Comments * Swiftlint * Unit tests * Add error validation for invalid verification contact * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Moved code to KnonwnESTSAPIErrorCodes * Moved to error case * Controller code * Linked controllers * Fix infinite allocation loop and empty verification contact * New SignIn method * Fix Unit tests * Removed not needed code * Split functions to handlers for responses * Update MSAL/src/native_auth/controllers/jit/MSALNativeAuthJITController.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Removed unused parameter * Removed not needed swiftlint * Removed not needed username * Changed general error to browser required * removed not needed config * Renamed jitRequired to jitAuthMethodsSelectionRequired Moved logic to jitcontroller * changed incorrect error * Added preverified path * refactor, remove task inside of task * Finished moving away from the on... parameters Combined both signIn functions from the protocol into one * Removed redirect case from introspect endpoints * Renamed to HandleTokenResult * Integration tests * Added comment * Unit tests * Unit tests * PR Comments --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> Co-authored-by: Danilo Raspa <daniloraspa@microsoft.com> * IC * Removed incorrect unit test host * Removed incorrect extra msal.framework * Swiftlint * Preverified --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> Co-authored-by: Danilo Raspa <daniloraspa@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the network layer along with the validation for it for JIT
Type of change
Risk
Additional information