[iOS SDK] JIT Registration, Business implementation #2583

spetrescu84 · 2025-04-16T21:07:48Z

Proposed changes

Add the business logic along with the dispatching and state creation for JIT

Type of change

Risk

High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Unit tests to follow

…SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>

….com/AzureAD/microsoft-authentication-library-for-objc into spetrescu/jit-network-implementation

nilo-ms · 2025-04-17T10:43:03Z

MSAL/src/native_auth/controllers/sign_in/MSALNativeAuthSignInController.swift

+            // TODO: This we need to clarify how we handle
+            Task {
+                let jitController = createJITController()
+                let jitIntrospectResponse = await jitController.getJITAuthMethods(continuationToken: continuationToken,


Actually the name of "onJITRequired" is not accurate. With this name I thought that the caller of this function is notified if "registrationRequired" error is returned. While, in this case we call the "verification/introspect" API here. So, here I see two paths:

We let the caller decide what to do once "verificationRequired" is called. Most probably it will do something similar you did in line 856 - 870

We rename the callback to "onJITAuthMethodsSelectionRequired", and we let the JIT controller handle this logic internally. So, the signIn controller delegate to the JIT controller the handling of "registrationRequired" as much as possible and just call the "onJITAuthMethodsSelectionRequired" or "onError".

I prefer approach 2.

Changed the controller response to return the state directly and moved that logic to the jit controller.
Renamed to onJITAuthMethodsSelectionRequired

Updated to not use withCheckedContinuation except for the MSIDHandler

nilo-ms · 2025-04-17T10:44:12Z

...responses/validator/jit/validated_response/MSALNativeAuthJITChallengeValidatedResponse.swift

+    func convertToRegisterStrongAuthChallengeError(correlationId: UUID) -> RegisterStrongAuthChallengeError {
+        switch self {
+        case .redirect:
+            return .init(type: .generalError, correlationId: correlationId)


I though we want to convert this to "browser required" error.

It should be browserRequired, fixed

nilo-ms · 2025-04-17T10:46:29Z

.../responses/validator/jit/validated_response/MSALNativeAuthJITContinueValidatedResponse.swift

+    func convertToRegisterStrongAuthSubmitChallengeError(correlationId: UUID) -> RegisterStrongAuthSubmitChallengeError {
+        switch self {
+        case .redirect:
+            return .init(type: .generalError, correlationId: correlationId)


It should be browserRequired, fixed

...responses/validator/jit/validated_response/MSALNativeAuthJITChallengeValidatedResponse.swift

MSAL/src/native_auth/public/state_machine/delegate/JITDelegates.swift

Moved logic to jitcontroller

Combined both signIn functions from the protocol into one

…t-implementation

nilo-ms · 2025-04-17T21:22:00Z

MSAL/src/native_auth/network/responses/validator/jit/MSALNativeAuthJITResponseValidator.swift

+                MSALLogger.logPII(
+                    level: .error,
+                    context: context,
+                    format: "register/challenge: Invalid response with challenge type preverified, response: \(MSALLogMask.maskPII(response))")


nit: can you mention that "continuation token was expected"?

…t-implementation

…mplementation

* Native auth: Just in time SDK mock interface (#2555) * add new state and delegate for JIT * add mock implementation and update for signIn after singUp and SSPR delegates * Add callback also to signIn password delegate * make jit state methods public * use right callback method name * [iOS SDK] JIT Registration, Network implementation (#2576) * Added JIT classes * Jit classes * Controllers * New controllers * Moved controller * Changes for PR * Cleanup * Revert controller changes * Reverted changes on dispatchers * Fixed unit tests * remove non network files * Unit tests * Removed failing tests * PR comments * PR Comments * Swiftlint * Unit tests * Add error validation for invalid verification contact * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Moved code to KnonwnESTSAPIErrorCodes * Moved to error case * Integration tests * Added comment --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * [iOS SDK] JIT Registration, Business implementation (#2583) * Added JIT classes * Jit classes * Controllers * New controllers * Moved controller * Changes for PR * Cleanup * Revert controller changes * Reverted changes on dispatchers * Fixed unit tests * remove non network files * Unit tests * Removed failing tests * PR comments * PR Comments * Swiftlint * Unit tests * Add error validation for invalid verification contact * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Moved code to KnonwnESTSAPIErrorCodes * Moved to error case * Controller code * Linked controllers * Fix infinite allocation loop and empty verification contact * New SignIn method * Fix Unit tests * Removed not needed code * Split functions to handlers for responses * Update MSAL/src/native_auth/controllers/jit/MSALNativeAuthJITController.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> * Removed unused parameter * Removed not needed swiftlint * Removed not needed username * Changed general error to browser required * removed not needed config * Renamed jitRequired to jitAuthMethodsSelectionRequired Moved logic to jitcontroller * changed incorrect error * Added preverified path * refactor, remove task inside of task * Finished moving away from the on... parameters Combined both signIn functions from the protocol into one * Removed redirect case from introspect endpoints * Renamed to HandleTokenResult * Integration tests * Added comment * Unit tests * Unit tests * PR Comments --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> Co-authored-by: Danilo Raspa <daniloraspa@microsoft.com> * IC * Removed incorrect unit test host * Removed incorrect extra msal.framework * Swiftlint * Preverified --------- Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com> Co-authored-by: Danilo Raspa <daniloraspa@microsoft.com>

spetrescu84 and others added 29 commits April 8, 2025 14:54

Added JIT classes

9b192ed

Jit classes

d457009

Controllers

dfc9ee3

New controllers

0825907

Moved controller

471bab5

Changes for PR

198e59f

Cleanup

093f10b

Revert controller changes

496d8c5

Reverted changes on dispatchers

1715d7c

Fixed unit tests

931d3c5

remove non network files

a253bff

Unit tests

79dae7b

Removed failing tests

474049a

PR comments

ebc6f9a

PR Comments

b0bca23

Swiftlint

9a2747a

Unit tests

b1f6526

Add error validation for invalid verification contact

ca66623

Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/…

db9ae17

…SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>

Update MSAL/src/native_auth/public/state_machine/delegate_dispatcher/…

3c6d2c1

…SignInDelegateDispatchers.swift Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>

Moved code to KnonwnESTSAPIErrorCodes

d4c9157

Merge branch 'spetrescu/jit-network-implementation' of https://github…

d442e58

….com/AzureAD/microsoft-authentication-library-for-objc into spetrescu/jit-network-implementation

Moved to error case

2ef5035

Controller code

4347ad5

Linked controllers

d8a15af

Fix infinite allocation loop and empty verification contact

e80cf12

New SignIn method

7940ca2

Fix Unit tests

47d40d6

Removed not needed code

4191806

spetrescu84 self-assigned this Apr 16, 2025

Removed not needed username

bff3c62

nilo-ms reviewed Apr 17, 2025

View reviewed changes

...responses/validator/jit/validated_response/MSALNativeAuthJITChallengeValidatedResponse.swift Outdated Show resolved Hide resolved

Changed general error to browser required

5ba4d85

nilo-ms reviewed Apr 17, 2025

View reviewed changes

MSAL/src/native_auth/public/state_machine/delegate/JITDelegates.swift Show resolved Hide resolved

nilo-ms reviewed Apr 17, 2025

View reviewed changes

MSAL/src/native_auth/public/state_machine/delegate/JITDelegates.swift Outdated Show resolved Hide resolved

spetrescu84 and others added 10 commits April 17, 2025 12:29

removed not needed config

6b3351a

Renamed jitRequired to jitAuthMethodsSelectionRequired

8afe863

Moved logic to jitcontroller

changed incorrect error

14440dd

Added preverified path

da005a5

refactor, remove task inside of task

aae9c65

Finished moving away from the on... parameters

e9b880a

Combined both signIn functions from the protocol into one

Removed redirect case from introspect endpoints

7ff9c4f

Renamed to HandleTokenResult

0385499

Integration tests

0abcba4

Merge branch 'spetrescu/jit-network-implementation' into spetrescu/ji…

e0f82e5

…t-implementation

nilo-ms reviewed Apr 17, 2025

View reviewed changes

nilo-ms approved these changes Apr 17, 2025

View reviewed changes

spetrescu84 marked this pull request as ready for review April 17, 2025 22:06

spetrescu84 added 4 commits April 17, 2025 23:14

Added comment

13b4bc8

Merge branch 'spetrescu/jit-network-implementation' into spetrescu/ji…

57fce69

…t-implementation

Unit tests

3d70268

Unit tests

f182260

spetrescu84 changed the base branch from spetrescu/jit-network-implementation to feature/just-in-time-registration April 22, 2025 08:58

spetrescu84 added 2 commits April 22, 2025 10:46

Merge branch 'feature/just-in-time-registration' into spetrescu/jit-i…

0e16d63

…mplementation

PR Comments

1420399

spetrescu84 merged commit 2286125 into feature/just-in-time-registration Apr 22, 2025
1 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[iOS SDK] JIT Registration, Business implementation #2583

[iOS SDK] JIT Registration, Business implementation #2583

Uh oh!

spetrescu84 commented Apr 16, 2025

Uh oh!

nilo-ms Apr 17, 2025

Uh oh!

spetrescu84 Apr 17, 2025

Uh oh!

spetrescu84 Apr 17, 2025

Uh oh!

nilo-ms Apr 17, 2025

Uh oh!

spetrescu84 Apr 17, 2025

Uh oh!

nilo-ms Apr 17, 2025

Uh oh!

spetrescu84 Apr 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nilo-ms Apr 17, 2025

Uh oh!

spetrescu84 Apr 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[iOS SDK] JIT Registration, Business implementation #2583

[iOS SDK] JIT Registration, Business implementation #2583

Uh oh!

Conversation

spetrescu84 commented Apr 16, 2025

Proposed changes

Type of change

Risk

Additional information

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants