Support sovereign cloud. #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was largely based on some hallway communication, which happened to not work in sovereign scenario. Neither did we test sovereign scenario for MSAL Python, until now.
yugangw-msft
approved these changes
Jun 17, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was based on some hallway communication 3 years ago. Sovereign scenario was not brought up at that time, and such implementation happened to not work in sovereign scenarios.
PS: ADAL Python happened to use a different implementation which was not susceptible to this issue.
The actual fix is just a one-liner. The rest are refactoring, notes and test cases adjustments.
@yugangw-msft , would you mind to test it by pulling it from this branch?
Once tested and merged, this PR will fix #59 .