Fix for #415 #428
Merged
Fix for #415 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Aug 10, 2020
jennyf19
reviewed
Aug 10, 2020
| context.ProtocolMessage.DomainHint = domainHint; | ||
|
|
||
| // delete the domainHint from the Properties when we are done otherwise | ||
| // it will take up extra space in the cookie. | ||
| context.Properties.Parameters.Remove(OpenIdConnectParameterNames.DomainHint); |
There was a problem hiding this comment.
Thanks for the contribution @durandt, this is great. We already have a test verifying the doman_hint is set, but not sure if we want to check one or the other as well, or this test is enough...personally, I'm okay with this current test and the work done here. cc: @jmprieur
jennyf19
reviewed
Aug 10, 2020
src/Microsoft.Identity.Web/WebAppExtensions/WebAppAuthenticationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
8 tasks
…onBuilderExtensions.cs
|
thanks again @durandt |
|
Well, that wasn't much job 😊 Thank you @jennyf19 , that was fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domain_hint ingored when login_hint is set.
Break up code so that domain_hint and login_hint are treated
independently.