Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #415 #428

Merged
merged 2 commits into from
Aug 10, 2020
+10 −3
Merged

Fix for #415 #428

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a919f0
Fix for #415
ThibaultDurand2023 Aug 10, 2020
60f7b0d
Update src/Microsoft.Identity.Web/WebAppExtensions/WebAppAuthenticati…
jennyf19 Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/Microsoft.Identity.Web/WebAppExtensions/WebAppAuthenticationBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,19 @@ public static AuthenticationBuilder AddMicrosoftWebApp(
if (!string.IsNullOrWhiteSpace(login))
{
context.ProtocolMessage.LoginHint = login;
context.ProtocolMessage.DomainHint = context.Properties.GetParameter<string>(
OpenIdConnectParameterNames.DomainHint);

// delete the login_hint and domainHint from the Properties when we are done otherwise
// delete the login_hint from the Properties when we are done otherwise
// it will take up extra space in the cookie.
context.Properties.Parameters.Remove(OpenIdConnectParameterNames.LoginHint);
}

var domainHint = context.Properties.GetParameter<string>(OpenIdConnectParameterNames.DomainHint);
if (!string.IsNullOrWhiteSpace(domainHint))
{
context.ProtocolMessage.DomainHint = domainHint;

// delete the domainHint from the Properties when we are done otherwise
jennyf19 marked this conversation as resolved.
Show resolved Hide resolved
// it will take up extra space in the cookie.
context.Properties.Parameters.Remove(OpenIdConnectParameterNames.DomainHint);
Copy link
Collaborator

@jennyf19 jennyf19 Aug 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @durandt, this is great. We already have a test verifying the doman_hint is set, but not sure if we want to check one or the other as well, or this test is enough...personally, I'm okay with this current test and the work done here. cc: @jmprieur

}

Expand Down