Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to support Azure functions #856

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Conversation

maliksahil
Copy link
Contributor

Changes are in AzureFunctionsAuthenticationHttpContextExtension.cs.

@maliksahil maliksahil requested a review from jmprieur January 6, 2021 22:02
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliksahil
LGTM

  • I suggested a change in the XML comment for the method.
  • @jennyf19, I think we should also add the test app?

public static class AzureFunctionsAuthenticationHttpContextExtension
{
/// <summary>
/// Enables Bearer authentication for an API for use in Azure Functions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about?
Enables an Azure Function to act as/expose a protected web API, enabling bearer token authentication? Calling this method from your Azure function validates the token and exposes the identity of the user or app on behalf of which your function is called, in the HttpContext.User member, where your function can exploit it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmprieur what do you mean by add the test app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm PR is approved, should I still go ahead and edit this description? New PR or same?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maliksahil go ahead and edit. as it's a fork, @jmprieur or i will have to merge it. thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!! :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Microsoft.Identity.Web helps authenticating Azure Functions with AAD and B2C
3 participants