-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes to support Azure functions #856
Conversation
src/Microsoft.Identity.Web/AzureFunctionsAuthenticationHttpContextExtension.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web/AzureFunctionsAuthenticationHttpContextExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/AzureFunctionsAuthenticationHttpContextExtension.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliksahil
LGTM
- I suggested a change in the XML comment for the method.
- @jennyf19, I think we should also add the test app?
public static class AzureFunctionsAuthenticationHttpContextExtension | ||
{ | ||
/// <summary> | ||
/// Enables Bearer authentication for an API for use in Azure Functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about?
Enables an Azure Function to act as/expose a protected web API, enabling bearer token authentication? Calling this method from your Azure function validates the token and exposes the identity of the user or app on behalf of which your function is called, in the HttpContext.User
member, where your function can exploit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmprieur what do you mean by add the test app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm PR is approved, should I still go ahead and edit this description? New PR or same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maliksahil go ahead and edit. as it's a fork, @jmprieur or i will have to merge it. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennyf19, I meant the sample using the new API: https://github.com/maliksahil/ms-identity-azurefunctions-microsoft-identity-web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarCloud Quality Gate failed. |
Changes are in AzureFunctionsAuthenticationHttpContextExtension.cs.