-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes to support Azure functions #856
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
src/Microsoft.Identity.Web/AzureFunctionsAuthenticationHttpContextExtension.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System; | ||
using System.Threading.Tasks; | ||
using Microsoft.AspNetCore.Authentication; | ||
using Microsoft.AspNetCore.Http; | ||
using Microsoft.AspNetCore.Mvc; | ||
|
||
namespace Microsoft.Identity.Web | ||
{ | ||
/// <summary> | ||
/// Extensions for <see cref="AzureFunctionsAuthenticationHttpContextExtension"/>. | ||
/// </summary> | ||
public static class AzureFunctionsAuthenticationHttpContextExtension | ||
{ | ||
/// <summary> | ||
/// Enables Bearer authentication for an API for use in Azure Functions. | ||
/// </summary> | ||
/// <param name="httpContext">The current HTTP Context, such as req.HttpContext.</param> | ||
/// <returns>A task indicating success or failure. In case of failure <see cref="Microsoft.AspNetCore.Mvc.UnauthorizedObjectResult"/>.</returns> | ||
public static async Task<(bool, IActionResult?)> AuthenticateAzureFunctionAsync( | ||
this HttpContext httpContext) | ||
{ | ||
if (httpContext == null) | ||
{ | ||
throw new ArgumentNullException(nameof(httpContext)); | ||
} | ||
maliksahil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
AuthenticateResult? result = | ||
await httpContext.AuthenticateAsync(Constants.Bearer).ConfigureAwait(false); | ||
if (result != null && result.Succeeded) | ||
{ | ||
httpContext.User = result.Principal; | ||
return (true, null); | ||
} | ||
else | ||
{ | ||
return (false, new UnauthorizedObjectResult(new ProblemDetails | ||
{ | ||
Title = "Authorization failed.", | ||
Detail = result?.Failure?.Message, | ||
})); | ||
} | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about?
Enables an Azure Function to act as/expose a protected web API, enabling bearer token authentication? Calling this method from your Azure function validates the token and exposes the identity of the user or app on behalf of which your function is called, in the
HttpContext.User
member, where your function can exploit it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmprieur what do you mean by add the test app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm PR is approved, should I still go ahead and edit this description? New PR or same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maliksahil go ahead and edit. as it's a fork, @jmprieur or i will have to merge it. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennyf19, I meant the sample using the new API: https://github.com/maliksahil/ms-identity-azurefunctions-microsoft-identity-web