Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦋 Add (optional) be-BOP logo on PoS QR code #1614 #1619

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

ithiame
Copy link
Contributor

@ithiame ithiame commented Dec 3, 2024

No description provided.

@ithiame ithiame linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have this in SVG instead?

Copy link
Contributor

@Tirodem Tirodem Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bebop-b
I hope github won't do a svg to png conversion again like in the original issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grmpf.
bebop-b.zip

src/routes/(app)/pos/session/+page.svelte Outdated Show resolved Hide resolved
src/routes/(app)/pos/session/+page.svelte Outdated Show resolved Hide resolved
coyotte508
coyotte508 previously approved these changes Dec 5, 2024
@Tirodem
Copy link
Contributor

Tirodem commented Dec 6, 2024

image
image
While QR code is readable, display is not good (depending of the PoS display device size & resolution) ❌

@coyotte508
Copy link
Collaborator

coyotte508 commented Dec 6, 2024

Indeed

The logo should directly be integrated in the SVG - in the qrcode url - please include screenshots in your future PRs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG contains a lot of useless metadata:

<svg
   id="oo"
   viewBox="0 0 370.82057 561.73657"
   version="1.1"
   sodipodi:docname="bebop-b.svg"
   inkscape:version="1.1.2 (b8e25be833, 2022-02-05)"
   width="370.82059"
   height="561.73657"
   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
   xmlns="http://www.w3.org/2000/svg"
   xmlns:svg="http://www.w3.org/2000/svg">
  <sodipodi:namedview
     id="namedview915"
     pagecolor="#ffffff"
     bordercolor="#666666"
     borderopacity="1.0"
     inkscape:pageshadow="2"
     inkscape:pageopacity="0.0"
     inkscape:pagecheckerboard="0"
     showgrid="false"
     inkscape:zoom="0.20831121"
     inkscape:cx="1024.9088"
     inkscape:cy="1459.355"
     inkscape:window-width="1920"
     inkscape:window-height="1017"
     inkscape:window-x="-8"
     inkscape:window-y="-8"
     inkscape:window-maximized="1"
     inkscape:current-layer="oo"
     fit-margin-top="0"
     fit-margin-left="0"
     fit-margin-right="0"
     fit-margin-bottom="0" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made quickly with Inkscape from the main be-BOP svg logo, my bad, we'll upload a cleaner SVG later 🙊

@coyotte508
Copy link
Collaborator

coyotte508 commented Dec 6, 2024

Done

image

Note that you can edit the assets/bebop-b.svg if you want it to be larger (so whitespace is added on the sides)

When you edit it, make sure to remove the top-level fields (<xml, xmlns:...) or it won't be able to be embed

You can also edit https://github.com/B2Bitcoin/beBOP/pull/1619/files#diff-169d2550c7553bfba7a531d0683ff93b6ee9e3eb7b3466c9e337cdf0334b918aR12 to change the size of the logo

Copy link
Contributor

@Tirodem Tirodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests are OK ✅

@Tirodem Tirodem merged commit 6d2599e into main Dec 6, 2024
3 checks passed
@Tirodem Tirodem deleted the optional-bebop-logo-on-qr branch December 6, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🦋 Add (optional) be-BOP logo on PoS QR code
3 participants