-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦋 Add (optional) be-BOP logo on PoS QR code #1614 #1619
Conversation
src/lib/assets/logo-bebop.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have this in SVG instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grmpf.
bebop-b.zip
Indeed The logo should directly be integrated in the SVG - in the |
src/lib/assets/bebop-b.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVG contains a lot of useless metadata:
<svg
id="oo"
viewBox="0 0 370.82057 561.73657"
version="1.1"
sodipodi:docname="bebop-b.svg"
inkscape:version="1.1.2 (b8e25be833, 2022-02-05)"
width="370.82059"
height="561.73657"
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
xmlns="http://www.w3.org/2000/svg"
xmlns:svg="http://www.w3.org/2000/svg">
<sodipodi:namedview
id="namedview915"
pagecolor="#ffffff"
bordercolor="#666666"
borderopacity="1.0"
inkscape:pageshadow="2"
inkscape:pageopacity="0.0"
inkscape:pagecheckerboard="0"
showgrid="false"
inkscape:zoom="0.20831121"
inkscape:cx="1024.9088"
inkscape:cy="1459.355"
inkscape:window-width="1920"
inkscape:window-height="1017"
inkscape:window-x="-8"
inkscape:window-y="-8"
inkscape:window-maximized="1"
inkscape:current-layer="oo"
fit-margin-top="0"
fit-margin-left="0"
fit-margin-right="0"
fit-margin-bottom="0" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made quickly with Inkscape from the main be-BOP svg logo, my bad, we'll upload a cleaner SVG later 🙊
Done Note that you can edit the When you edit it, make sure to remove the top-level fields ( You can also edit https://github.com/B2Bitcoin/beBOP/pull/1619/files#diff-169d2550c7553bfba7a531d0683ff93b6ee9e3eb7b3466c9e337cdf0334b918aR12 to change the size of the logo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests are OK ✅
No description provided.