Skip to content

Commit

Permalink
remove get_highest_tag_version from converters (#831)
Browse files Browse the repository at this point in the history
  • Loading branch information
CagtayFabry authored Jan 2, 2023
1 parent b825db9 commit db750a4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ dependencies

- pin ``asdf<2.14`` due to changes in the extension mechanism [:pull:`828`].

changes
=======

- remove outdated calls to ``weldx.asdf.util.get_highest_tag_version`` in ``TimeSeries`` and ``SpatialData`` converters [:pull:`831`]

********************
0.6.2 (07.11.2022)
********************
Expand Down
5 changes: 0 additions & 5 deletions weldx/tags/core/geometry/spatial_data.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from copy import copy

from weldx.asdf.types import WeldxConverter
from weldx.asdf.util import get_highest_tag_version
from weldx.geometry import SpatialData

__all__ = ["SpatialDataConverter"]
Expand All @@ -27,7 +26,3 @@ def from_yaml_tree(self, node: dict, tag: str, ctx) -> SpatialData:
if tag == "asdf://weldx.bam.de/weldx/tags/core/geometry/spatial_data-0.1.0":
node["coordinates"] = Q_(node["coordinates"], "mm") # legacy
return SpatialData(**node)

def select_tag(self, obj, tags, ctx) -> str:
"""Determine the output tag for serialization."""
return get_highest_tag_version(self.tags)
5 changes: 0 additions & 5 deletions weldx/tags/core/time_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from asdf.tagged import TaggedDict

from weldx.asdf.types import WeldxConverter
from weldx.asdf.util import get_highest_tag_version
from weldx.constants import Q_
from weldx.core import TimeSeries

Expand Down Expand Up @@ -46,10 +45,6 @@ def from_yaml_tree(self, node: dict, tag: str, ctx):

return TimeSeries(node["expression"]) # mathexpression

def select_tag(self, obj, tags, ctx) -> str:
"""Determine the output tag for serialization."""
return get_highest_tag_version(self.tags)

@staticmethod
def shape_from_tagged(node: TaggedDict) -> list[int]:
"""Calculate the shape from static tagged tree instance."""
Expand Down

0 comments on commit db750a4

Please sign in to comment.