Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove get_highest_tag_version from converters #831

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

CagtayFabry
Copy link
Member

Changes

  • remove get_highest_tag_version and use default tag selection in TimeSeries and SpatialData converters

Checks

  • updated CHANGELOG.rst

@CagtayFabry CagtayFabry added the ASDF everything ASDF related (python + schemas) label Dec 22, 2022
@github-actions
Copy link

github-actions bot commented Dec 22, 2022

Test Results

2 184 tests  ±0   2 183 ✔️ ±0   2m 41s ⏱️ +13s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 3803954. ± Comparison against base commit b825db9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #831 (3803954) into master (b825db9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   96.83%   96.82%   -0.01%     
==========================================
  Files          92       92              
  Lines        6061     6055       -6     
==========================================
- Hits         5869     5863       -6     
  Misses        192      192              
Impacted Files Coverage Δ
weldx/tags/core/geometry/spatial_data.py 94.11% <ø> (-0.89%) ⬇️
weldx/tags/core/time_series.py 96.66% <ø> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CagtayFabry CagtayFabry marked this pull request as ready for review December 22, 2022 11:16
@CagtayFabry CagtayFabry requested a review from marscher December 23, 2022 09:37
@CagtayFabry
Copy link
Member Author

thank you for pointing these out @marscher
I have left get_highest_tag_version in there for now because it might be needed for the docs build (sphinx-asdf fork)

@marscher marscher enabled auto-merge (squash) January 2, 2023 09:49
@marscher marscher merged commit db750a4 into BAMWelDX:master Jan 2, 2023
@CagtayFabry CagtayFabry deleted the update_converters branch January 2, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants