Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asdf-2.14.1 leads to a condition where weldx extension is found twice. #825

Closed
marscher opened this issue Nov 24, 2022 · 10 comments · Fixed by #834
Closed

asdf-2.14.1 leads to a condition where weldx extension is found twice. #825

marscher opened this issue Nov 24, 2022 · 10 comments · Fixed by #834
Labels
ASDF everything ASDF related (python + schemas) bug Something isn't working

Comments

@marscher
Copy link
Contributor

This makes get_weldx_extension() fail, as the weldx extension is meant to be found only once. Eventually we register our extension in a legacy manner.
Downgrading to asdf-2.13 circumvents this problem.

@marscher marscher added bug Something isn't working ASDF everything ASDF related (python + schemas) labels Nov 24, 2022
@marscher
Copy link
Contributor Author

marscher commented Nov 24, 2022

It seems one Extension contains all converters and tags, and the other does only contain tags.
Screenshot_20221124_145829

@marscher marscher mentioned this issue Nov 28, 2022
5 tasks
@marscher
Copy link
Contributor Author

marscher commented Dec 1, 2022

Note that I released a quick fix build for conda-forge pinning asdf to <2.14

@marscher
Copy link
Contributor Author

marscher commented Dec 1, 2022

xref conda-forge/weldx-feedstock#22

@marscher
Copy link
Contributor Author

marscher commented Dec 6, 2022

@CagtayFabry another interesting observation is that on asdf-2.13 the legacy flag of the extension is False, while in asdf-2.14 it is True. But I cannot spot this change in upstream extension handling... Note that even asdf's extension is a legacy on 2.14

Its weird :hurtrealbad:

@CagtayFabry
Copy link
Member

@CagtayFabry another interesting observation is that on asdf-2.13 the legacy flag of the extension is False, while in asdf-2.14 it is True. But I cannot spot this change in upstream extension handling... Note that even asdf's extension is a legacy on 2.14

Its weird :hurtrealbad:

that is indeed really weird, I suggest bringing this up in asdf-format/asdf#1254 too and looking for clarification with the asdf devs on what is happening here

I have not followed the 2.14 release in depth so far

@marscher
Copy link
Contributor Author

marscher commented Dec 6, 2022

It looks like if you have an editable install (which we also do for our Github action pipeline), we get duplicated entry points.

@CagtayFabry CagtayFabry mentioned this issue Dec 6, 2022
1 task
@WilliamJamieson
Copy link
Contributor

I think ASDF (thanks @braingram) may have fixed this bug in asdf-format/asdf#1260. Can you confirm that this resolves your bug? If so we will do a bugfix release ASAP for you.

@CagtayFabry
Copy link
Member

I think ASDF (thanks @braingram) may have fixed this bug in asdf-format/asdf#1260. Can you confirm that this resolves your bug? If so we will do a bugfix release ASAP for you.

We will look into it, thank you for the heads up! @WilliamJamieson 🚀

@marscher
Copy link
Contributor Author

@WilliamJamieson Thanks for providing this fix. It works like expected!

@marscher
Copy link
Contributor Author

fixed upstream by asdf-format/asdf#1260

WilliamJamieson added a commit to WilliamJamieson/weldx that referenced this issue Jan 3, 2023
@WilliamJamieson WilliamJamieson mentioned this issue Jan 3, 2023
1 task
marscher pushed a commit that referenced this issue Jan 5, 2023
* Unpin asdf from above as asdf 2.14.3 fixes issue #825

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants