-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin ASDF #834
Unpin ASDF #834
Conversation
Thank you @WilliamJamieson 😊 We will probably consolidate this with #829 and discard older asdf versions for the next release to clean up some APIs as well (we are just slightly behind on the PRs over the holiday season 😉) |
No problem, I noticed in the ASDF downstream tests that weldx was pinning ASDF, which made pip complain. However, everything seemed to be passing. I didn't even check to see if you had a PR unpinning ASDF, so feel free to close this PR if you want. |
I prefer this kind of pinning, where the incompatible versions are listed explicitly. Thanks a lot! |
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 92 92
Lines 6055 6055
=======================================
Hits 5863 5863
Misses 192 192 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I agree, however we don't currently run any compatibility tests for older asdf versions |
Changes
This PR unpins asdf. In asdf version 2.14.3 we specifically fixed the bug introduced in asdf 2.14.0 which lead to #825. This means weldx should be able to unpin asdf now.
Note that I specifically excluded the asdf versions: 2.14.0, 2.14.1, and 2.14.2 as they all experience the bug reported in #825.
Related Issues
Closes #825
Checks