Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GithubActions] Test old ASDF minor versions #835

Merged
merged 7 commits into from
Jan 5, 2023

Conversation

marscher
Copy link
Contributor

@marscher marscher commented Jan 5, 2023

Changes

Run asdf tests against all (supported) minor versions of ASDF.

Related Issues

Related #834, #829

@marscher marscher added ASDF everything ASDF related (python + schemas) no-changelog-entry-needed labels Jan 5, 2023
@marscher marscher marked this pull request as ready for review January 5, 2023 13:18
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #835 (fa8c44e) into master (706cc95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          92       92           
  Lines        6071     6071           
=======================================
  Hits         5879     5879           
  Misses        192      192           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marscher marscher force-pushed the test_old_asdf_minor_versions branch from e54766b to fa8c44e Compare January 5, 2023 13:47
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Test Results

2 184 tests  ±0   2 183 ✔️ ±0   2m 29s ⏱️ -36s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit fa8c44e. ± Comparison against base commit 706cc95.

♻️ This comment has been updated with latest results.

@marscher marscher merged commit 140a038 into master Jan 5, 2023
@marscher marscher deleted the test_old_asdf_minor_versions branch January 5, 2023 17:55
@CagtayFabry
Copy link
Member

the pip version takes priority over the conda install version I assume?

We could also add an exclude option to pydeps2env to do these kind of things

@marscher
Copy link
Contributor Author

marscher commented Jan 5, 2023

Excluding packages within the conda env would be really hard, as the solver would complain or lead to broken envs. And yes pip overtakes the slot of the conda pkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants