-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tutorials #555
New tutorials #555
Conversation
I created this branch as a base branch for all the upcoming tutorials. I will make a separate PR for each tutorial targetting this branch so that we can discuss the tutorials individually. |
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 96.12% 96.16% +0.03%
==========================================
Files 91 91
Lines 5941 5941
==========================================
+ Hits 5711 5713 +2
+ Misses 230 228 -2
Continue to review full report at Codecov.
|
@CagtayFabry @marscher I converted the test file in this branch to
To my understanding, this is probably caused by the pint short notations. But before I continue searching for the problem, can you (@marscher ) confirm that you get this error too and that it isn't just a wrong setup on my computer? You need to change the file extension in the corresponding notebook cell back to |
I'm receiving the same error. |
note, that this string directly comes from the asdf serialization. |
interesting, the notation is created by pint so wondering why it cannot load it in the meantime I suggest changing the serialization notation style for pint units back to 'long' format here weldx/weldx/tags/unit/pint_quantity.py Lines 58 to 60 in 1ea8be3
this should give the long notation again return f"{obj:.}" |
I will try that for now. I couldn't quickly pinpoint the field that was causing that since the python stack was cut at some point. I haven't done any deeper research since then |
I have asked about handling this notation with pint here hgrecco/pint#1390 |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
* [doc/conf] download single_pass_weld.weldx from iw repo It checks the hash of the current master. Eventually we should use a tagged version here to prevent hash missmatches in the future. * adopt url to tagged version * logger name * clean up * rm single_pass_weld.wx * revert nitpick ignore change. * set tutorials dir relative to conf.py file location * [conf] output file suffix set to .wx * lint Co-authored-by: Cagtay Fabry <43667554+CagtayFabry@users.noreply.github.com>
added tutorials/util.py download single_pass_weld.weldx from iw repo func
can you give a quick update on what is missing here @vhirtham ? |
Nothing missing, we just didn't want to include it in the last release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just need to update the changelog entry
Changes
Adds a set of new tutorials as discussed here
Related Issues
Closes #400
Checks
single_pass_weld.wx