Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial about reading WelDX files #556

Merged

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Sep 23, 2021

Changes

Add the first tutorial about reading a WelDX file

@vhirtham vhirtham self-assigned this Sep 23, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vhirtham vhirtham added the documentation Improvements or additions to documentation label Sep 23, 2021
@vhirtham vhirtham mentioned this pull request Sep 23, 2021
6 tasks
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #556 (624cc94) into new_tutorials (d4def7d) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 624cc94 differs from pull request most recent head 42dceee. Consider uploading reports for the commit 42dceee to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##           new_tutorials     #556      +/-   ##
=================================================
+ Coverage          94.67%   94.71%   +0.03%     
=================================================
  Files                 93       93              
  Lines               5768     5768              
=================================================
+ Hits                5461     5463       +2     
+ Misses               307      305       -2     
Impacted Files Coverage Δ
weldx/asdf/file.py 96.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4def7d...42dceee. Read the comment docs.

@vhirtham vhirtham marked this pull request as ready for review October 13, 2021 14:22
@github-actions
Copy link

github-actions bot commented Oct 13, 2021

Unit Test Results

       1 files  ±  0         1 suites  ±0   3m 13s ⏱️ +41s
1 920 tests +18  1 920 ✔️ +18  0 💤 ±0  0 ±0 

Results for commit ef98163. ± Comparison against base commit 353f7b4.

♻️ This comment has been updated with latest results.

@vhirtham
Copy link
Collaborator Author

I think the first tutorial is now ready to be merged after I added the new info method. I also added a new section on the "Getting started" page for it.

Copy link
Member

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a hint that the tutorials are really supposed to run in an interactive environment rather than the static homepage to work best

@vhirtham vhirtham changed the title Tutorial about reading WelDX files Add tutorial about reading WelDX files Oct 21, 2021
@vhirtham vhirtham merged commit 43f0f94 into BAMWelDX:new_tutorials Oct 21, 2021
@vhirtham vhirtham deleted the tutorial_reading_introduction branch October 21, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants