Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set meshio<5.2 for sphinx builds #673

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

CagtayFabry
Copy link
Member

Changes

Related Issues

Closes #672

I am not sure why this only pops up in the sphinx build, do we have a test using meshio? @vhirtham

@CagtayFabry CagtayFabry added documentation Improvements or additions to documentation CI dependencies changes in package dependencies no-changelog-entry-needed labels Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #673 (6568313) into master (463f949) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          91       91           
  Lines        5941     5941           
=======================================
  Hits         5713     5713           
  Misses        228      228           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463f949...6568313. Read the comment docs.

@github-actions
Copy link

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 8s ⏱️ +35s
1 949 tests ±0  1 949 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6568313. ± Comparison against base commit 463f949.

@CagtayFabry CagtayFabry merged commit 7ac937b into BAMWelDX:master Dec 18, 2021
@CagtayFabry CagtayFabry deleted the sphinx_meshio branch December 18, 2021 19:30
@vhirtham
Copy link
Collaborator

I am not sure why this only pops up in the sphinx build, do we have a test using meshio? @vhirtham

Not that I am aware of

@marscher
Copy link
Contributor

I have encountered several of these circular import errors during loading Sphinx conf.py. That's why there is this workaround function to load modules like xarray and pandas. I cannot make anything of that strange behaviour as you noticed it only happens in Sphinx builds. So its probably related to the "changed" import behaviour there.

marscher added a commit to marscher/weldx that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI dependencies changes in package dependencies documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meshio import errors on sphinx builds
3 participants