Prevent circular ImportError meshio #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marscher
added
documentation
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 92 92
Lines 6307 6307
=======================================
Hits 6046 6046
Misses 261 261 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Preload meshio to avoid Sphinx circular ImportError.
This issue might arise from the fact, that the conf.py file is being passed to exec with its own globals dictionary. This is why we only observe these import errors in Sphinx, but not during daily usage of weldx. Perhaps we should report this upstream.
Follow up to #673
Checks