Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctests #734

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix doctests #734

merged 2 commits into from
Apr 5, 2022

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Apr 5, 2022

Changes

Fix doctest failure due to new pint version

Related Issues

@vhirtham vhirtham added bug Something isn't working no-changelog-entry-needed labels Apr 5, 2022
@CagtayFabry
Copy link
Member

we might let the pint team know that the new formatting system will remove the default setting for unit formatting with syntax like :.2f (it worked with 0.18)

@CagtayFabry CagtayFabry self-requested a review April 5, 2022 10:57
@vhirtham
Copy link
Collaborator Author

vhirtham commented Apr 5, 2022

Now it's official... this week is the worst one regarding dependencies -.- Fixed one problem to get another... https://readthedocs.org/projects/weldx/builds/16566272/

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #734 (19d4107) into master (af9df21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          92       92           
  Lines        6496     6496           
=======================================
  Hits         6229     6229           
  Misses        267      267           
Impacted Files Coverage Δ
weldx/geometry.py 96.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038b5bb...19d4107. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Unit Test Results

       1 files  ±0         1 suites  ±0   3m 2s ⏱️ +5s
2 158 tests ±0  2 158 ✔️ +2  0 💤 ±0  0  - 2 

Results for commit 19d4107. ± Comparison against base commit 038b5bb.

@vhirtham vhirtham merged commit 027b279 into BAMWelDX:master Apr 5, 2022
@vhirtham vhirtham deleted the fix_doctests branch April 5, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants