-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Ruff linter pre-commit actions #824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
=======================================
Coverage 96.82% 96.83%
=======================================
Files 92 92
Lines 6055 6071 +16
=======================================
+ Hits 5863 5879 +16
Misses 192 192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I think the config looks very clean now that nbqa-ruff is also available @marscher 👍 Just some errors to look into with the latest versions |
we could also think about removing isort for the ruff implementation |
With ruff-0.0.208 the error output does not contain the originating file name. This renders the output useless. |
oh that sounds bad, I hope ruff will introduce an option to toggle this at least..? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow great work digging through all of it @marscher 🙏
the linting config also looks super clean 👍
Thanks! |
Changes
Note that I also removed flake8-deprecations, which only checked for a hard coded dictionary of super old deprecations inside the std lib.
Checks