Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: do not use subsample index to get actual targets in UnivariateProbabilitySimulator #303

Merged
merged 3 commits into from
Sep 22, 2021
Merged

FIX: do not use subsample index to get actual targets in UnivariateProbabilitySimulator #303

merged 3 commits into from
Sep 22, 2021
+13 −5

Conversation

j-ittner
Copy link
Member

This PR fixes a bug introduced in v1.2 that caused class UnivariateProbabilitySimulator to terminate with a error

@j-ittner j-ittner added the bug Something isn't working label Sep 22, 2021
@j-ittner j-ittner added this to the 1.2.1 milestone Sep 22, 2021
@j-ittner j-ittner self-assigned this Sep 22, 2021
bhadurishirsesh
bhadurishirsesh approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@bhadurishirsesh bhadurishirsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reviewed the change to _simulation.py and not the unit tests.

@j-ittner j-ittner merged commit d50418c into 1.2.x Sep 22, 2021
@j-ittner j-ittner deleted the fix/univariate_probability_simulator_expected_output_subsample branch September 22, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhadurishirsesh bhadurishirsesh bhadurishirsesh approved these changes

Assignees

@j-ittner j-ittner

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@j-ittner @bhadurishirsesh