Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Default environment panel types #2795

Closed
charliebrookerBH opened this issue Apr 21, 2022 · 1 comment · Fixed by #3170
Closed

Environment_Engine: Default environment panel types #2795

charliebrookerBH opened this issue Apr 21, 2022 · 1 comment · Fixed by #3170
Assignees
@charliebrookerBH @jamesramsden-bh @albinber
Labels
type:feature New capability or enhancement
Milestone
BHoM 6.1 β MVP

Comments

@charliebrookerBH
Copy link

Description:

The default panel type assignment for from to spaces isn't intuitive.
image

Can we change it so that:
SlabOnGrade to Floor
WallExternal to Wall
Roof to Ceiling

Thanks!
@charliebrookerBH charliebrookerBH added the type:feature New capability or enhancement label Apr 21, 2022
@FraserGreenroyd
Copy link
Contributor

Following chat with @rboulton-BH offline last night, the best way to resolve this is to have additional inputs than just one panelType that asks people to specify which panel type they want to use for the following options:

  • Roof
  • Ceiling
  • Floor
  • External grounding
  • External walls
  • Internal walls

They can default to the current options so users don't have to plug in multiple options if they're happy with the defaults (as it currently is) but allows advanced users to have more granular control over the model building 😄

@FraserGreenroyd FraserGreenroyd removed their assignment Apr 22, 2022
@emilsvedjer emilsvedjer removed their assignment Jul 28, 2022
@rboulton-BH rboulton-BH assigned kprusicka and unassigned rboulton-BH Dec 22, 2022
@rboulton-BH rboulton-BH added this to the BHoM 6.1 β MVP milestone Dec 22, 2022
@FraserGreenroyd FraserGreenroyd assigned albinber and unassigned EKAdebo and kprusicka Sep 1, 2023
@FraserGreenroyd FraserGreenroyd changed the title Default environment panel types Environment_Engine: Default environment panel types Sep 1, 2023
FraserGreenroyd pushed a commit that referenced this issue Sep 1, 2023
Add optional panel type inputs to SetRoofPanels method as part of #2795
3e341ac
@albinber albinber mentioned this issue Sep 4, 2023
Merged
FraserGreenroyd pushed a commit that referenced this issue Sep 4, 2023
Add optional panel type inputs to SetRoofPanels method as part of #2795
72616a1
FraserGreenroyd pushed a commit that referenced this issue Sep 11, 2023
Add optional panel type inputs to SetRoofPanels method as part of #2795
ed3039e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliebrookerBH charliebrookerBH

@jamesramsden-bh jamesramsden-bh

@albinber albinber

Labels
type:feature New capability or enhancement
Projects
Building Environments Priority
Status: Completed
Milestone
BHoM 6.1 β MVP
Development

Successfully merging a pull request may close this issue.

Environment_Engine: Intuitive default environmental panel types BHoM/BHoM_Engine
9 participants
@FraserGreenroyd @charliebrookerBH @rboulton-BH @jamesramsden-bh @robinflyman @emilsvedjer @EKAdebo @kprusicka @albinber