Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Intuitive default environmental panel types #3170

Merged

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 4, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #2795

Test files

Changelog

Additional comments

@albinber albinber added the type:feature New capability or enhancement label Sep 4, 2023
@albinber albinber self-assigned this Sep 4, 2023
@albinber
Copy link
Contributor Author

albinber commented Sep 4, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd FraserGreenroyd changed the title Environment_Engine #2795 Intuitive default environmental panel types Environment_Engine: Intuitive default environmental panel types Sep 4, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also resolve the documentation compliance issues @albinber 😄

Environment_Engine/Create/Panel.cs Show resolved Hide resolved
Environment_Engine/Create/Panel.cs Show resolved Hide resolved
albinber and others added 3 commits September 4, 2023 12:44
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@albinber
Copy link
Contributor Author

albinber commented Sep 4, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and works well, great job @albinber - not an easy task but a great introduction to our versioning system given the number of methods changed 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit cb49d17 into develop Sep 4, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2795-intuitivepaneltypes branch September 4, 2023 15:55
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Default environment panel types
2 participants