-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Intuitive default environmental panel types #3170
Environment_Engine: Intuitive default environmental panel types #3170
Conversation
@BHoMBot check compliance |
@albinber to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also resolve the documentation compliance issues @albinber 😄
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@BHoMBot check compliance |
@albinber to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and works well, great job @albinber - not an easy task but a great introduction to our versioning system given the number of methods changed 😄
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #2795
Test files
Changelog
Additional comments