Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.3 Deployment #3178

Merged
merged 145 commits into from
Sep 21, 2023
Merged

6.3 Deployment #3178

merged 145 commits into from
Sep 21, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Sep 11, 2023

BHoM_Engine

Feature

Bug

Compliance

Test-script

Documentation

Uncategorised

Copy link

@JohnSloane JohnSloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with the Lighting_Engine test methods, all passed.

Copy link
Contributor

@JohannaOlin1 JohannaOlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Environment_Engine using BHoM_6.3.230919.beta.0.msi and all tests passed

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving:

  • Diffing_Engine with 230915 6.3 installer and related test procedure
  • Analytical_Engine (Graph) with 230915 6.3 installer and related test procedure

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on ETABS_Toolkit

@alexissantella
Copy link
Contributor

Tested MEP_Engine 20/9 Passed.

@gideontamir16
Copy link

Tested using Facade_Engine procedure. Passed

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

Please be advised that the check with reference 16981029710 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 29 additional annotations waiting, made up of 0 errors and 29 warnings.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 18 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

The check beta-core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

The check beta-null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

The check beta-serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: beta-code-compliance, beta-documentation-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, documentation-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Checked by DevOps following Testing Sprint. Everything is satisfactory, DevOps clear to merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 7f7abd8 into main Sep 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.