-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: FromJson()
to Trim the text before attempting to read it
#3110
Serialiser_Engine: FromJson()
to Trim the text before attempting to read it
#3110
Conversation
FromJson()
to Trim the text before attempting to read it FromJson()
to Trim the text before attempting to read it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets the job done so happy to approve.
Note: I have only done a review based on the code but this PR is simple enough that I am confident it works and doesn't break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense based on the issue described, happy to approve for merge and testing via alphas.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #3109
The json text is trimmed before attempting to read it. See #3109 for a longer description.
This helps solving issues reading files with trailing/initial newlines/whitespaces, in particular for workflows that @pawelbaran highlighted in BHoM/File_Toolkit#161 (if you go there, make sure you read its closing comment BHoM/File_Toolkit#161 (comment)).
Test files
Attached in #3109.
Changelog
Additional comments