Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Removed string to enum method from AssignSpaceTypeByPoint #3171

Merged

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 5, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #3121

Test files

Changelog

Additional comments

@albinber albinber added the type:documentation Wiki, help or in code attributes label Sep 5, 2023
@albinber albinber self-assigned this Sep 5, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 35 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check installer
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check installer
  • check core
  • check null-handling
  • check serialisation

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 72 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, unit-tests

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method is deleted per issue and discussion, good to go.

@FraserGreenroyd FraserGreenroyd changed the title Environment_Engine: Removed string to enum method from AssignSpaceTypeByPoint.cs Environment_Engine: Removed string to enum method from AssignSpaceTypeByPoint Sep 5, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 0a970dc into develop Sep 5, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#3121-RemovingStringToEnum branch September 5, 2023 19:57
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environments Engine Removing string to enum converter method from AssignSpaceTypeByPoint.cs
2 participants