Geometry_Engine: Adding methods required by IElement2D for PlanarSurface

[IsakNaslundBh]

NOTE: Depends on

BHoM/BHoM#1390

Issues addressed by this PR

Closes #2812

Adding methods required for IElement2D.

For planar surfaces, the InternalElement2Ds will be returned as a set of new PLanarSurfaces, with ExternalBoundaries correpsonding to the InternalBoundaries of the host PlanarSurface. This is to fullfill the requirement that the openings must also be IElement2D, which is not the case for the closed curves. This workaround alows for the methods to behave as expected.

Potential at one point to add some form of Region class, that is like the PlanarSurface, but without any openings. There is no practical use for that class though, that can not be achieved with a PlanarSurface with no openings, more than clarity for methods like this. For now, I think this is the best solution forward, even it it at first might look slightly unintuitive.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EgJ3TMjsnNFBkM_sPjRKDewBcjco6-8OogC7UcSvS3lMKw?e=g8munn

Changelog

Additional comments

Reference to the wikipage outlining methods required by the IElement framework:

https://github.com/BHoM/documentation/wiki/IElement-required-extension-methods

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

There are 561 requests in the queue ahead of you.

[alelom]

Good in general, see comments

[alelom]

Tested using test scripts, approving based on latest changes and discussion in comments

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

There are 130 requests in the queue ahead of you.

[bhombot-ci]

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

[bhombot-ci]

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

[IsakNaslundBh]

@BHoMBot check null-handling

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• null-handling

There are 127 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

There are 126 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check required

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

There are 135 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

[alelom]

Re-approving after null handling fixes

[IsakNaslundBh]

@BHoMBot check ready-to-merge

[bhombot-ci]

@IsakNaslundBh to confirm, the following checks are now queued:

• ready-to-merge

There are 118 requests in the queue ahead of you.