-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.1 Deployment #445
7.1 Deployment #445
Conversation
Replaced existing NuGet package (ETABS v1) with updated NuGet package (CSiAPIv1)
… adapter is toggled on (#444)
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-code-compliance. If you are providing dispensation on this occasion, please reply with:
|
1 similar comment
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-code-compliance. If you are providing dispensation on this occasion, please reply with:
|
… inheritance for this object in next milestone
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 87 requests in the queue ahead of you. |
@bhombot-ci[bot] just to let you know, I have provided a |
1 similar comment
@bhombot-ci[bot] just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the changes to the code and I'm happy with it.
I've also tested and reviewed sections 01 to 09 of the Test Procedure for Structural Adapters using the 240324 Alfa Installer. All good globally and happy with it. I've noted the main areas/items to be improved moving forward at the following link:
240326 Notes and Comments.txt
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, serialisation, dataset-compliance, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs have been reviewed by DevOps and bot checks and are suitable for deployment for updating copyright headers to 2024. Approving for merge.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs have been reviewed by DevOps and are suitable for the deployment of develop
to the 7.1 beta. Approving for merge.
@bhombot-ci[bot] just to let you know, I have provided a |
ETABS_Toolkit
Bug
Compliance
Documentation