Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change inheritance for PierForce #455

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 3, 2024

Issues addressed by this PR

Closes #447

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/EWEdqsW6RwlKipogK2deoTIBaMctYiF38inJzHUCDtG19g?e=opbGFs

Changelog

  • Updated inheritance for PierForce and removed inheritance of BarForce;

@peterjamesnugent peterjamesnugent added the type:compliance Non-conforming to code guidelines label Jul 3, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Jul 3, 2024
@peterjamesnugent peterjamesnugent self-assigned this Jul 3, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 3, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@GCRA101
Copy link
Contributor

GCRA101 commented Jul 15, 2024

@peterjamesnugent , I've pulled the pier forces from a sample ETABS Model using the BHoM 7.3 Alpha version released on 15/07/2024. I've both internalised the pier forces in a GH script as well as serialized in JSON format. You can find the json file attached. Let me know how it goes. ;)
20240715_ETABS Pier Forces.json

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Jul 25, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jul 25, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jul 25, 2024

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jul 25, 2024

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jul 25, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

GCRA101
GCRA101 previously approved these changes Aug 6, 2024
Copy link
Contributor

@GCRA101 GCRA101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the code using the latest Alpha of the BHoM on the date 06/08/2024.
I've used the grasshopper script #445-ChangeInheritancePierForce.gh for the test and the parameters of the PierForce objects are extracted as expected.
See screenshots attached for evidence.
GHScriptWithOutputs

@peterjamesnugent

Changes approved.

Copy link
Contributor

@GCRA101 GCRA101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the code directly exporting the pier forces from a sample etabs model.
All working fine and as expected.

Changes approved.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 16, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Aug 16, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 16, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 16, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented Aug 16, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 16, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link

bhombot-ci bot commented Aug 16, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 112887e into develop Aug 16, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#447-ChangeInheritanceForPierForce branch August 16, 2024 12:38
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change inheritance for PierForce class
3 participants