-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change inheritance for PierForce #455
Change inheritance for PierForce #455
Conversation
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@peterjamesnugent , I've pulled the pier forces from a sample ETABS Model using the BHoM 7.3 Alpha version released on 15/07/2024. I've both internalised the pier forces in a GH script as well as serialized in JSON format. You can find the json file attached. Let me know how it goes. ;) |
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the code using the latest Alpha of the BHoM on the date 06/08/2024.
I've used the grasshopper script #445-ChangeInheritancePierForce.gh for the test and the parameters of the PierForce objects are extracted as expected.
See screenshots attached for evidence.
Changes approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the code directly exporting the pier forces from a sample etabs model.
All working fine and as expected.
Changes approved.
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #447
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EWEdqsW6RwlKipogK2deoTIBaMctYiF38inJzHUCDtG19g?e=opbGFs
Changelog
PierForce
and removed inheritance ofBarForce
;