Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the empty Adapter project #116

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Removed the empty Adapter project #116

merged 1 commit into from
Oct 25, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 25, 2019

Issues addressed by this PR

Closes #115

@alelom alelom self-assigned this Oct 25, 2019
@alelom alelom added this to the BHoM 3.0 β MVP milestone Oct 25, 2019
@alelom alelom changed the title Removed the emtpy Adapter project Removed the empty Adapter project Oct 25, 2019
epignatelli
epignatelli approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the bases that the current project has no functionalities.
Although, it may become helpful in the future to treat Rhinoceros as a generic adapter - e.g. move data to a database from excel.

@epignatelli epignatelli merged commit d10b86f into master Oct 25, 2019
@epignatelli epignatelli deleted the #115-removeAdapterProject branch October 25, 2019 15:41
This was referenced Oct 30, 2019
Closed
Merged
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epignatelli epignatelli epignatelli approved these changes

Assignees

@alelom alelom

Labels
None yet
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Remove the empty Adapter project
2 participants
@alelom @epignatelli