Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rhinoceros_Toolkit: Delete the Rhinoceros_Adapter files #118

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Rhinoceros_Toolkit: Delete the Rhinoceros_Adapter files #118

merged 1 commit into from
Oct 30, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 30, 2019 •
edited
Loading

Description

After #116 the Adapter project was removed from the solution but I forgot to delete the files.
People using the "big BHoM solution" will still have it loading so it needs to be deleted.

Issues addressed by this PR

Closes #117

@alelom alelom changed the title Delete the Rhinoceros_Adapter files Rhinoceros_Toolkit: Delete the Rhinoceros_Adapter files Oct 30, 2019
@alelom alelom self-assigned this Oct 30, 2019
@alelom alelom added this to the BHoM 3.0 β MVP milestone Oct 30, 2019
kThorsager
kThorsager approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look deleted

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue size:XS Measured in seconds type:bug Error or unexpected behaviour labels Oct 30, 2019
peterjamesnugent
peterjamesnugent approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles with changes made in PR.

@al-fisher al-fisher merged commit 4ae77a4 into master Oct 30, 2019
@al-fisher al-fisher deleted the #117-deleteAdapterFiles branch October 30, 2019 16:57
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kThorsager kThorsager kThorsager approved these changes

@peterjamesnugent peterjamesnugent peterjamesnugent approved these changes

@epignatelli epignatelli Awaiting requested review from epignatelli

Assignees

@alelom alelom

Labels
severity:critical No workaround exists. Essential to continue size:XS Measured in seconds type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Delete the unused Adapter project
4 participants
@alelom @peterjamesnugent @kThorsager @al-fisher