Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create converts for trimmed surfaces #122

Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Nov 12, 2019

NOTE: Depends on

#603
#1319

Issues addressed by this PR

Closes #119

Test files

Test files are located on SharePoint. To run it, please switch to the branches related to the following PRs:

The error in Rhino -> BHoM -> Rhino convert error in the test file is caused by the bug in Cone convert logged here.

Changelog

  • Converts for trimmed nurbs surfaces have been added following changes in the NurbsSurface definition.

Additional comments

Updated copy of #120.
Please see #603.

Actions to be taken after this PR gets merged:

Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pawelbaran !

The test files are not working to me, though.
IsClosed:

1. Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

IsPeriodic:

1. Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

IToBHoM:

1. This component failed to run properly. Output data is calculated but cannot be set.
Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

IToRhino:

1. This component failed to run properly. Are you sure you have the correct type of inputs?
Check their description for more details. Here is the error provided by the method:
Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index

I am using all the branches described. is there anything I am doing wrong?
image

Rhinoceros_Engine/Convert/ToBHoM.cs Outdated Show resolved Hide resolved
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the code works very well in terms of functionalities., thanks @pawelbaran !

The only thing is that it is not very readable - I left some comments in there.

Also, could you update the conversion table based on the changes in this pr?

Rhinoceros_Engine/Convert/ToBHoM.cs Outdated Show resolved Hide resolved
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks very much @pawelbaran !

@FraserGreenroyd FraserGreenroyd removed their request for review November 15, 2019 12:20
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See general comment here: BHoM/Revit_Toolkit#435 (review)

@al-fisher al-fisher merged commit 37b0ef9 into master Nov 16, 2019
@al-fisher al-fisher deleted the BHoM-Issue425-CreationOfTrimmedNurbsSurfaceDefinition branch November 16, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rhinoceros_Engine: Create converts for trimmed surfaces
3 participants