Geometry_Engine: NurbsSurfaces: Degrees() fix and IsClosed, IsPeriodic implementation #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
requested review from
rwemay,
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
epignatelli
pawelbaran
changed the title
pawelbaran
requested review from
adecler
and removed request for
FraserGreenroyd
This was referenced Nov 12, 2019
epignatelli
reviewed
Nov 14, 2019
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp why are you giving us a red tick? @FraserGreenroyd any idea? |
|
Command 'why' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
@epignatelli see BHoM/Test_Toolkit#68 - trying to look into this this morning 😄 |
|
/azp run BHoM_Engine.CheckCore |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Should be fixed now @epignatelli 😄 |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
epignatelli
approved these changes
Nov 15, 2019
al-fisher
approved these changes
Nov 16, 2019
There was a problem hiding this comment.
Happy with this approach as noted on related BHoM PR.
Thanks @pawelbaran
al-fisher
deleted the
BHoM-Issue425-CreationOfTrimmedNurbsSurfaceDefinition
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
#603
Issues addressed by this PR
Closes #1297
Closes #1320
Test files
Test files are located on SharePoint. To run it, please switch to the branches related to the following PRs:
The error in Rhino -> BHoM -> Rhino convert error in the test file is caused by the bug in Cone convert logged here.
Changelog
BH.Engine.Geometry.Query.Degrees(this NurbsSurface surf)has been removed.BH.Engine.Geometry.Query.IsClosed(this NurbsSurface surface)has been added.BH.Engine.Geometry.Query.IsPeriodic(this NurbsSurface surface)has been added.Additional comments
Updated copy of #1298.
Please see #603.
Issues to be raised after merging this:
InternalEdges(NurbsSurface surface)andExternalEdges(NurbsSurface surface)inBH.Engine.Geometry.Query