Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables costum set (local) axis when pushing loads to Robot #271

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

JonathanNillius
Copy link
Contributor

Issues addressed by this PR

Closes #270

I pasted the code that allows for custom axis to be set into the if statements that creates the load if it exists.

Test files

https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?csf=1&e=CJWjNz&cid=0b727f4a%2Daf39%2D4d1d%2D8942%2D0c26c33d7c20&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4&viewid=a5a93cba%2Dfcca%2D46cc%2Da31a%2D80b8d5cbfd7b&id=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FTest%20Scripts%2FRobot%5FToolkit%2FRobot%5FToolkit%2DPR%20push%20load%20with%20local%20axis

how to test:
open test grasshopper file, toggle everything to true and look in the Robot loadtable to see if the axis is local:
image

Additional comments

pasted statement as mentioned in the issue
@JonathanNillius JonathanNillius added type:bug Error or unexpected behaviour status:WIP PR in progress and still in draft, not ready for formal review labels Oct 24, 2019
@JonathanNillius JonathanNillius self-assigned this Oct 24, 2019
@JonathanNillius JonathanNillius removed the status:WIP PR in progress and still in draft, not ready for formal review label Oct 24, 2019
@IsakNaslundBh IsakNaslundBh requested a review from alelom October 25, 2019 13:45
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot_Toolkit: Can't push load with local axis
2 participants