Aligning with changes in BHoMAdapter Refactoring Level 04

[IsakNaslundBh]

NOTE: Depends on

BHoM/BHoM_Engine#1371
BHoM/BHoM_Adapter#164
BHoM/BHoM_UI#167

• If you use Grasshopper: Aligning with changes in BHoMAdapter Refactoring Level 04 Grasshopper_UI#440

• If you use Excel: https://github.com/BHoM/Excel_Toolkit/pull/172

• If you use Dynamo: Aligning with changes in BHoMAdapter Refactoring Level 04 Dynamo_UI#188

• If your Toolkit needs Socket_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Socket_Toolkit#57

• If your Toolkit needs Mongo_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Mongo_Toolkit#82

• If you want the Adapter components to be automatically upgraded to their new version in your test scripts: Adding support for method upgrade Versioning_Toolkit#8

Issues addressed by this PR

Closes #288

Test files

[alelom]

Code LGTM. Tested Push. Need to finish testing tomorrow morning.

[kThorsager]

Looked through the code and did some minor tests,

RobotAdapter.cs has some private methods under its public header, minor thing but still

There is an enum: command in Robot_oM, but it's empty? If whatever planed functionality it had has been take over by the adapter commands it should be removed.

In Execute Analyse ignore warnings is set to true, but warnings still appear (noticed for instability, lack of section and when results are overwritten)

AnalyseLoadCases does sometimes run more commands than it's told, as in I have three loadcases, run one through AnalyseLoadCases and get the results for the one I want and an other.
If I run the one that's always added, that is the only one.

And If I try to re-run another load case, then I only get the results for the one that always appear or both, depending on load case.
Not sure whats going on

[IsakNaslundBh]

Thanks @kThorsager

RobotAdapter.cs has some private methods under its public header, minor thing but still

think those are fine. Very robot specific methods right now used by various parts of the adapter. To me those makes sense in there at least.

There is an enum: command in Robot_oM, but it's empty? If whatever planed functionality it had has been take over by the adapter commands it should be removed.

Good catch! Might leave this to a general refactoring/cleanup of the toolkit as not really affected by this though

In Execute Analyse ignore warnings is set to true, but warnings still appear (noticed for instability, lack of section and when results are overwritten)

AnalyseLoadCases does sometimes run more commands than it's told, as in I have three loadcases, run one through AnalyseLoadCases and get the results for the one I want and an other.
If I run the one that's always added, that is the only one.

And If I try to re-run another load case, then I only get the results for the one that always appear or both, depending on load case.
Not sure whats going on

Will try to have a look at this if resolveable quickly before merge deadline

[alelom]

Tested so far:

• Push of elements (scripts in _Macro folder)
• Pull of elements (scripts in _Macro folder)
• Pull of results (just added a script that was coming from Robot_Toolkit: Update Result extraction to be working with new Requests #277 in _Macro folder)

all working fine.

[alelom]

Approved in light of latest changes by @IsakNaslundBh . If other issues will be found, we'll raise a bug issue.

[kThorsager]

While all of my issues haven't been resolved, I have been promised that issues will be raised and since they were minor and not necessarily related to this refactoring I would say that this looks good, (and works).