Add member lengths to FramingElementDesignProperties #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
requested changes
Jan 16, 2020
There was a problem hiding this comment.
From a first look, this looks good!
WIll put this on hold, and put a request change for this reason, until after #293 has been merged though, as it could lead to some conflicts!
|
@IsakNaslundBh #293 has now been merged so this can be looked at again yes? It has a couple of conflicts, might be good to sort out with @johannaisak next week? This PR also requires a suitable label for the change log please. |
|
Adressed by #323 to align with restructuring of the toolkit |
johannaisak
deleted the
Robot_Toolkit-#295-AddMemberLengthToFramingElementDesignProperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #295
Reads and sets member lengths in X and Y and toggles for whether lengths are real or relative. Happy for input on parameter naming and improvements to the code.
Test files
Test files
Changelog
Additional comments