errorcode returns add #5147
Closed
errorcode returns add #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AenBleidd
requested changes
Mar 15, 2023
| @@ -256,7 +256,7 @@ HRESULT CreateProcessWithExplorerIL(LPWSTR szProcessName, LPWSTR szCmdLine) | |||
| &ProcInfo | |||
| ); | |||
| if(!bRet) { | |||
| hr = HRESULT_FROM_WIN32(GetLastError()); | |||
| return(HRESULT_FROM_WIN32(GetLastError())); | |||
There was a problem hiding this comment.
At this moment hNewToken, hToken, hProcess won't be properly released
|
Closed in favor of #5170 with better implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4178
Description of the Change
immediate return add after fault
Alternate Designs
does not have idea
Release Notes
immediate return add after fault