[Windows Installer] Prevent handle leaks

[BrianNixon]

Fixes #4178

[talregev]

@BrianNixon
Is it interning you implementing the new installer?
#5064

[AenBleidd]

@BrianNixon

Is it interning you implementing the new installer?

#5064

Definitely not because there is no decision yet about the new installer toolkit

[talregev]

Is it interesting you to do this research?

[BrianNixon]

Is it interesting you to do this research?

At the moment I don’t know enough about installers, or BOINC’s setup needs, to be able to take on that task.

I just picked an easy ‘Newbie’ bug to fix…

[talregev]

Is it interesting you to do this research?

At the moment I don’t know enough about installers, or BOINC’s setup needs, to be able to take on that task.

I just picked an easy ‘Newbie’ bug to fix…

Let me know when you feel ready. Thank you for your fix!

The task is to learn about the installers.
Also it written on the issue a full list of boinc needs from the new installer.

[AenBleidd]

Is it interesting you to do this research?

I believe this should be done by me and the decision should be made by me as well

[AenBleidd]

Looks good to me

[talregev]

Is it interesting you to do this research?

I believe this should be done by me and the decision should be made by me as well

As you pointed out in the issue you don't have time for that. So stop blocking others for helping the boinc community.

[AenBleidd]

As you pointed out in the issue you don't have time for that. So stop blocking others for helping the boinc community.

I don't stop anybody. I'm just saying that this is a complex task, and it's probably better if I do this.
If somebody else has experience - they are always welcome to contribute.

[talregev]

As you pointed out in the issue you don't have time for that. So stop blocking others for helping the boinc community.

I don't stop anybody. I'm just saying that this is a complex task, and it's probably better if I do this. If somebody else has experience - they are always welcome to contribute.

If you say it probably should done by me, it blocking people from learning and give the information for windows installer.

[AenBleidd]

If you say it probably should done by me, it blocking people from learning and give the information for windows installer.

At first, this is not a correct place for such a discussion.
Second, I expressed my opinion, because this is really something that could be more effectively done by me rather than by someone who just starts to learn BOINC codebase. But I still don't block anyone from doing that.